Clarify usage of super-dense time instants #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@klausschuch can you comment on this PR? Can we merge it? |
klausschuch
reviewed
Sep 24, 2024
| @@ -355,6 +355,9 @@ FMU 1 receives a `Confirm` operation, because the specified frame with CAN ID 15 | |||
| [#figure-can-arbitration-overview] | |||
| image::can_arbitration_overview.svg[width=80%, align="center"] | |||
|
|
|||
| _[Note: The number and use of super-dense time instants may differ depending on the implementation. | |||
| Only one possible path is given here, which is permitted by the FMI specification.]_ | |||
There was a problem hiding this comment.
Since this isn't normative text but a guide, We should maybe emphasis that this is the intended way of doing it and just mention that other implementations are valid due to certain tool restrictions. (same below)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@klausschuch does this fix your comment "Figure 3 of LS-Bus implementers Guide: Why is integer part of super dense time increased. This is not described in the standard."? I think your are correct and I had to clarify that the sequence diagrams just show one way of a solution.