Added clarification on time increment #114
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmai
reviewed
Sep 10, 2024
| @@ -61,6 +61,10 @@ With FMI 2.0 Co-Simulation FMUs do not support 0-size time steps in any case. | |||
| With FMI 3.0, Co-Simulation FMUs can support event handling explicitly via the `hasEventMode` capability flag. | |||
| Importers can make use of this feature by passing `fmi3True` for the `eventModeUsed` argument of the `fmi3InstantiateCoSimulation` call. | |||
|
|
|||
| === Time increment | |||
|
|
|||
| An accurate simulation is dependent on an accurate increment of time. The importer must therefore set the current simulation time in a non-error-cumulative manner. As the actual implementation of the time increment is importer specific and unknown to the imported FMU, the FMU itself should not make any assumptions about the precision of the next time steps. | |||
There was a problem hiding this comment.
Suggested change
| An accurate simulation is dependent on an accurate increment of time. The importer must therefore set the current simulation time in a non-error-cumulative manner. As the actual implementation of the time increment is importer specific and unknown to the imported FMU, the FMU itself should not make any assumptions about the precision of the next time steps. | |
| An accurate simulation is dependent on an accurate increment of time. | |
| The importer must therefore set the current simulation time in a non-error-cumulative manner. | |
| As the actual implementation of the time increment is importer specific and unknown to the imported FMU, the FMU itself should not make any assumptions about the precision of the next time steps. | |
| This can mean, for example, that even in a fixed-step simulation the individual `communicationStepSize` values will differ by very small amounts. |
Split into one sentence per line and added an explicit example of the last point which is maybe more on the nose for the target audience. Further discussion to be had in the next design meeting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24