Request to add Sakal FMU Generator to the tool list #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrbertsch
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Looks good.
It would be great if you could provide provide compatibility information (see https://github.com/modelica/fmi-standard.org/blob/main/CONTRIBUTING.md#compatibility-information), i.e. how you tested your FMI implementation? (Could also be in a separate Pull Request.)
Benefit: your tool will get the "yellow star" and be listed on the top.
|
This information seems super useful! Since it might take a little longer, I'll make a note to open another PR for it later. Just for my information, will someone work on merging this PR to the main branch. Thank you in advance for your support!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request is submitted to add Sakal FMU Generator to the tool list. A new request is submitted as the old PR # 639 was not accessible.