Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove examplesURL from "fmi_adapter for ROS" #668

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

t-sommer
Copy link
Collaborator

as the linked website does not provide the required compatibility information and all provided FMUs have invalid model descriptions.

@chrbertsch
Copy link
Collaborator

@ralph-lange : could you please update and validate the provided FMUs with the tools provided at https://fmi-standard.org/validation/, and describe with which FMUs from which exporting tools you have tested your FMI import (OpenModelica, Dymola?, Reference FMUs )

@t-sommer
Copy link
Collaborator Author

I think for now the provided information does not meet the required standards and should be removed. The authors can re-add an examplesURL any time.

Copy link
Collaborator

@chrbertsch chrbertsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK
@ralph-lange : please re-add the examplesURL once you have updated the information.

@ralph-lange
Copy link
Contributor

OK @ralph-lange : please re-add the examplesURL once you have updated the information.

Yes, let's proceed like that.

@t-sommer t-sommer merged commit 8eb2b36 into modelica:main Oct 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants