feat: Upgrades serialization v4 (Threaded Heap Serialization) #5915
Triggered via pull request
September 10, 2024 01:59
Status
Success
Total duration
5m 24s
Artifacts
–
build-test.yml
on: pull_request
Matrix: build-linux
Matrix: build-macos
Annotations
10 warnings and 3 notices
Build (MacOS 14)
icu4c 74.2 is already installed and up-to-date.
To reinstall 74.2, run:
brew reinstall icu4c
|
Build (MacOS 14)
zstd 1.5.6 is already installed and up-to-date.
To reinstall 1.5.6, run:
brew reinstall zstd
|
Build (MacOS 13)
icu4c 74.2 is already installed and up-to-date.
To reinstall 74.2, run:
brew reinstall icu4c
|
Build (MacOS 13)
zstd 1.5.6 is already installed and up-to-date.
To reinstall 1.5.6, run:
brew reinstall zstd
|
Build (MacOS 13)
argon2 20190702_1 is already installed and up-to-date.
To reinstall 20190702_1, run:
brew reinstall argon2
|
Expression is always 'null':
Projects/Server/Serialization/BinaryFileReader.cs#L46
Expression is always null
|
Redundant 'partial' modifier on type declaration:
Projects/Server/World/World.cs#L39
Partial class with single part
|
Private field can be converted into local variable:
Projects/Server/Serialization/SerializationThreadWorker.cs#L26
The field is always assigned before being used and can be converted into a local variable
|
Redundant using directive:
Projects/Server/Serialization/Persistence.cs#L17
Using directive is not required by the code and can be safely removed
|
Type member is never used (private accessibility):
Projects/Server/Serialization/GenericEntityPersistence.cs#L149
Method 'ReadTypes' is never used
|
Namespace does not correspond to file location:
Projects/Server/Serialization/SerializationThreadWorker.cs#L21
Namespace does not correspond to file location, must be: 'Server.Serialization'
|
Namespace does not correspond to file location:
Projects/Server/Serialization/IGenericSerializable.cs#L16
Namespace does not correspond to file location, must be: 'Server.Serialization'
|
Namespace does not correspond to file location:
Projects/Server/Serialization/BinaryFileReader.cs#L22
Namespace does not correspond to file location, must be: 'Server.Serialization'
|