feat: Adds PlayerDeathEvent and CreatureDeathEvent using CodeGeneratedEvents #1927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IcculusC
commented
Aug 13, 2024
kamronbatman
force-pushed
the
feat-mobile-death-event-sink
branch
2 times, most recently
from
ef3d126
to
948aef0
Compare
kamronbatman
changed the title
kamronbatman
reviewed
Sep 6, 2024
|
|
||
| EventSink.InvokePlayerDeath(this); |
There was a problem hiding this comment.
Crux of the change in this file.
kamronbatman
changed the title
kamronbatman
force-pushed
the
feat-mobile-death-event-sink
branch
from
a857f2c
to
9125e76
Compare
kamronbatman
reviewed
Sep 6, 2024
Comment on lines
-133
to
-141
| public static void OnLogin(Mobile m) | ||
| { | ||
| if (m?.Alive != false || _table[m] == null) | ||
| { | ||
| return; | ||
| } | ||
|
|
||
| HandleDeath_OnCallback(m); | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PlayerDeathEventandCreatureDeathEventusing code generated eventsImportant
Developer Note
Use
[OnEvent(nameof(PlayerMobile.PlayerDeathEvent))]instead ofEventSink.PlayerDeathdelegateCheck this commit for examples of how to use this.