Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added custom tls cert support #504

Merged
merged 6 commits into from
Apr 24, 2024
Merged

Added custom tls cert support #504

merged 6 commits into from
Apr 24, 2024

Conversation

Spitfireap
Copy link
Member

  • Allow user to set a pre-generated SSL cert (manual certificate added)
  • Added information regarding LetsEncrypt ToS

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Attention: Patch coverage is 17.85714% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 53.10%. Comparing base (7dcf69b) to head (e9a41dd).
Report is 31 commits behind head on master.

❗ Current head e9a41dd differs from pull request most recent head 18369e2. Consider uploading reports for the commit 18369e2 to get more accurate results

Files Patch % Lines
modoboa_installer/ssl.py 12.50% 21 Missing ⚠️
modoboa_installer/utils.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #504      +/-   ##
==========================================
- Coverage   54.40%   53.10%   -1.30%     
==========================================
  Files          10       10              
  Lines         761      789      +28     
==========================================
+ Hits          414      419       +5     
- Misses        347      370      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Spitfireap
Copy link
Member Author

Thanks to "jiwisd" on discord for the test.

@Spitfireap Spitfireap marked this pull request as ready for review June 23, 2023 15:58
@tonioo tonioo merged commit eb8bb21 into master Apr 24, 2024
6 checks passed
@tonioo tonioo deleted the custom-tls-fix branch April 24, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants