Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(snippet): Error that occurred when there were no linked resources in the document #372

Open
wants to merge 2 commits into
base: 3.x
Choose a base branch
from
Open

Fix(snippet): Error that occurred when there were no linked resources in the document #372

wants to merge 2 commits into from

Commits on Oct 2, 2024

  1. Fix(snippet): Error that occurred when there were no linked resources… 

    … in the document

When there are no linked resources in the document and the snippet getSelections is called, an error occurs due to an incorrectly composed query "sortby FIELD(...) in getSelections snippet.
Also, as far as I understand, it makes no sense to call the snippet getResources (pdoResources) if we already know that there are no linked resources. I suggest returning an empty result immediately if there are no linked resources in the document.
    @gitrequests
    gitrequests authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    de7e616 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. feat: ability to use snippet parameters for empty results in getSelec… 

    …tions

ability to use snippet parameters for empty results in getResources (pdoResources).
For example: &wrapIfEmpty
    @gitrequests
    gitrequests authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    a1e549b View commit details
    Browse the repository at this point in the history