Added userChallenge pagination #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moiskillnadne
approved these changes
Dec 8, 2024
There was a problem hiding this comment.
We should to mark each challenge according our new statuses and the startAtDate property.
If startAtDate === currentMonth -> ACTIVE
if startAtDate < currentMonth -> COMPLETED
src/api/userChallenge/controller.ts
Outdated
| @@ -110,16 +111,30 @@ route.get('/', async (req: Request, res: Response, next: NextFunction) => { | |||
| return next(new UnauthorizedError(ErrorMessages.unauthorized)); | |||
| } | |||
|
|
|||
| const status = req.query.status as ChallengeStatus; | |||
There was a problem hiding this comment.
I have added the validation lorgic here.
We always should work with safe/parsed values because we don`t know what we can get
|
I have fixed all the errors. @vmkhitaryanscn Please take a look at the changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added userChallenge pagination