-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mojaloop/#3636): batching implementation for position prepare messages #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vijayg10
changed the title
feat: added skeleton and comments for prepare bin implementation
feat: batching implementation for position prepare messages
Sep 7, 2023
32 tasks
…o feature/position-prepare-binnning
* feat: add position prepare bin logic * edit * lint * dep * chore: changes * chore: commet * lint * chore: refactor * chore: unit tests * chore: change * chore: comment * chore: test * chore: more test * chore: test? * chore: remove * chore: rework domain logic * chore: test * fix: position calculation * fix: position change data * fix; prepare domain function * chore: fix --------- Co-authored-by: Vijay <vijaya.guthi@infitx.com>
* chore: add tests * chore: unit * sleep * chore: clear * chore: test * enum * fix: deadlock in tests --------- Co-authored-by: Vijay <vijaya.guthi@infitx.com>
oderayi
changed the title
feat: batching implementation for position prepare messages
feat(mojaloop/#3636): batching implementation for position prepare messages
Nov 16, 2023
elnyry-sam-k
reviewed
Dec 4, 2023
elnyry-sam-k
reviewed
Dec 4, 2023
elnyry-sam-k
previously approved these changes
Dec 4, 2023
elnyry-sam-k
approved these changes
Dec 5, 2023
This was referenced Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(mojaloop/#3636): batching implementation for position prepare messages - mojaloop/project#3636
prepare
messagesuuidv4
with built-inrandomUUID
fromcrypto
nodejs librarybulk-prepare
messages are routed to non-batch prepare handler