Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL query analysis #11

Open
partiallyordered opened this issue Jan 6, 2020 · 2 comments
Open

SQL query analysis #11

partiallyordered opened this issue Jan 6, 2020 · 2 comments

Comments

@partiallyordered
Copy link
Contributor

partiallyordered commented Jan 6, 2020

PR #10 makes explicit a behaviour that was previously implicit.

Each of the queries modified in that PR should be evaluated for correctness and modified accordingly. As the functionality we've observed seems correct, it's likely that the queries are working correctly, however we should attempt to eliminate usage of ANY_VALUE by correct usage of GROUP BY, aggregate functions such as SUM, or introduction of explicit one-to-one relationships between the variables in the SELECT clause to prevent or minimise hard-to-debug issues in future.

@KamuelaFranco
Copy link
Member

@msk- Do those merges mean this can be closed?

@partiallyordered
Copy link
Contributor Author

No, not yet, I'm not aware that anyone has actually done a decent analysis of the usage of ANY_VALUE in the db queries. I somewhat expect that all usages thereof should disappear, but I'm a bit hesitant to declare as much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants