Addition of Financial portal and settlement services #233
Conversation
* Fix deployment probes names
aaronreynoza
requested review from
elnyry-sam-k,
KamuelaFranco,
partiallyordered,
shashi165 and
vbarzokas
There is no information about why they fail in the logs though, do you have a clue? |
My only hint was |
| metadata: | ||
| name: {{ .Values.config.is_populate.name | quote }} | ||
| labels: | ||
| app: {{ template "finance-portal.fullname" . }} |
There was a problem hiding this comment.
These labels are not following best practices --> https://helm.sh/docs/topics/chart_best_practices/labels/
See the following example: https://github.com/mojaloop/helm/blob/master/centralledger/chart-service/templates/deployment.yaml#L6
Please update.
| metadata: | ||
| name: {{ template "finance-portal.fullname" . }} | ||
| labels: | ||
| app: {{ template "finance-portal.fullname" . }} |
| kind: Deployment | ||
| metadata: | ||
| name: {{ template "finance-portal.fullname" . }} | ||
| labels: |
There was a problem hiding this comment.
Same comment about labels apply here.
| @@ -0,0 +1,20 @@ | |||
| apiVersion: extensions/v1beta1 | |||
| kind: Ingress | |||
| metadata: | |||
There was a problem hiding this comment.
Please add labels, and align to the above label comments.
settlement/templates/service.yaml
Outdated
| metadata: | ||
| name: {{ template "settlement.fullname" . }} | ||
| labels: | ||
| app: {{ template "settlement.name" . }} |
settlement/templates/service.yaml
Outdated
| protocol: TCP | ||
| name: http-settlement-management | ||
| selector: | ||
| app: {{ template "settlement.name" . }} |
| spec: | ||
| selector: | ||
| matchLabels: | ||
| app: {{ template "finance-portal.name" . }} |
There was a problem hiding this comment.
This has still not been updated?
| template: | ||
| metadata: | ||
| labels: | ||
| app: {{ template "finance-portal.name" . }} |
There was a problem hiding this comment.
This has still not been updated?
| apiVersion: v1 | ||
| kind: Secret | ||
| metadata: | ||
| name: {{ template "settlement.fullname" . }} | ||
| name: {{ template "portal-settlement.fullname" . }} |
There was a problem hiding this comment.
Would it be possible to use consistent naming with regard to portals?
I see that we have a finance-portal, then why not a settlement-portal?
There was a problem hiding this comment.
although I agree with consistent naming, settlement-portal maybe sounds like another portal. the service is a complement for the finance-portal, so perhaps finance-portal-settlement-management is a better name.
Please let me know what you think.
| metadata: | ||
| name: {{ template "portal-settlement.fullname" . }}-operator-settlement | ||
| labels: | ||
| app: {{ template "portal-settlement.fullname" . }} |
| metadata: | ||
| name: {{ template "portal-settlement.fullname" . }}-settlement-management | ||
| labels: | ||
| app: {{ template "portal-settlement.fullname" . }} |
| spec: | ||
| selector: | ||
| matchLabels: | ||
| app: {{ template "finance-portal-settlement-management.name" . }} |
| template: | ||
| metadata: | ||
| labels: | ||
| app: {{ template "finance-portal-settlement-management.name" . }} |
| protocol: TCP | ||
| name: http-settlement-management | ||
| selector: | ||
| app: {{ template "finance-portal-settlement-management.name" . }} |
| template: | ||
| metadata: | ||
| labels: | ||
| app: {{ template "finance-portal.name" . }} |
There was a problem hiding this comment.
This has still not been updated?
| spec: | ||
| selector: | ||
| matchLabels: | ||
| app: {{ template "finance-portal.name" . }} |
There was a problem hiding this comment.
This has still not been updated?
| protocol: TCP | ||
| name: http-finance-portal-ui | ||
| selector: | ||
| app: {{ template "finance-portal.name" . }} |
There was a problem hiding this comment.
This has still not been updated?
| description: Portal Settlement | ||
| name: finance-portal-settlement-management | ||
| version: 8.6.0 | ||
| appVersion: "8.6.0" |
| @@ -0,0 +1,6 @@ | |||
| apiVersion: v1 | |||
| appVersion: "1.0" | |||
…o finance-portal-service
This PR adds a new functionality to display the state of the financial platform:
a Finance portal that enables the interaction for multiple actions like transactions and settlement windows, which is a service of two containers: a back-end in Koa and a frontend in React:
This portal depends on the settlement service, which manages how the settlement windows are closed and how the settlements are saved, both actions being done in the settlement management and operator settlement respectively.
The portal can be accessed through a new NginX ingress that is being added in the mojaloop chart dependencies. This enables us to access the portal from outside the cluster.