Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3536 Liquidity Check and Fund adjustment process after settlement #35

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

#3536 Liquidity Check and Fund adjustment process after settlement #35

wants to merge 4 commits into from

Conversation

ryam-tw
Copy link
Contributor

@ryam-tw ryam-tw commented Nov 27, 2023

No description provided.

pedrosousabarreto
pedrosousabarreto requested changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@pedrosousabarreto pedrosousabarreto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments and requests to change, pls address them and resubmit.

packages/admin-ui/src/app/participants/pending-approvals.component.ts Outdated Show resolved Hide resolved
packages/admin-ui/src/app/participants/pending-approvals.component.ts Outdated Show resolved Hide resolved
packages/admin-ui/src/app/participants/pending-approvals.component.ts Outdated Show resolved Hide resolved
packages/admin-ui/src/app/app.module.ts Outdated Show resolved Hide resolved
packages/admin-ui/src/app/app.module.ts Outdated Show resolved Hide resolved
packages/admin-ui/src/app/_services_and_types/participants.service.ts Outdated Show resolved Hide resolved
packages/admin-ui/src/app/_services_and_types/participants.service.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nainglinnkhant nainglinnkhant nainglinnkhant left review comments

@pedrosousabarreto pedrosousabarreto pedrosousabarreto requested changes

@ruirochawork ruirochawork Awaiting requested review from ruirochawork ruirochawork is a code owner

@koekiebox koekiebox Awaiting requested review from koekiebox koekiebox is a code owner

@tw-aungthawaye tw-aungthawaye Awaiting requested review from tw-aungthawaye tw-aungthawaye is a code owner

@myo-min-htet myo-min-htet Awaiting requested review from myo-min-htet myo-min-htet is a code owner

@ZweHMyat ZweHMyat Awaiting requested review from ZweHMyat ZweHMyat is a code owner

@SithuKyaw-Thitsaworks SithuKyaw-Thitsaworks Awaiting requested review from SithuKyaw-Thitsaworks SithuKyaw-Thitsaworks is a code owner

@elnyry-sam-k elnyry-sam-k Awaiting requested review from elnyry-sam-k elnyry-sam-k is a code owner

@bushjames bushjames Awaiting requested review from bushjames bushjames is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryam-tw @pedrosousabarreto @nainglinnkhant