feat(3666): refactor quoting service into an event driven solution to improve performance #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ingHandler; updated tests
geka-evk
requested review from
mdebarros,
elnyry-sam-k,
oderayi,
vijayg10 and
bushjames
as code owners
Closed
24 tasks
geka-evk
changed the title
geka-evk
changed the title
vijayg10
reviewed
Dec 13, 2023
kleyow
reviewed
Dec 13, 2023
kleyow
reviewed
Dec 13, 2023
This reverts commit 5980d03.
vijayg10
changed the title
|
Lgtm. Just the CI, dep/audit updating discussed on slack. |
fix(mojaloop/#3739): Quote refactor to use Kafka - metrics regression - Added monitoring server (Hapi server) - Converted existing health check code to Hapi plugin and added it to the monitoring server - Added a metrics plugin - Update test coverage
vijayg10
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(3666): refactor quoting service into an event driven solution to improve performance.
The current quote service performs this action in memory, and a better solution would be to split the servce into two microservices with Kafka events. This will decouple the participant API responses from the work being performed and free's up the nodeJS IO threads.