-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tracking PR pisp/master #44
Open
eoln
wants to merge
10
commits into
main
Choose a base branch
from
pisp/master
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ci: handle `-pisp` tag to build a dedicated image * ci: use python3 & py-pip3 as dep for awsCli
* chore(swagger): add POST /authorization definition * feat(POST /authorizations): first draft * feat(POST /authorizations): implement minimal test * refactor(handlers): improve readability * chore: update deps & audit:resolve
* Poc/validation for names places accents (#37) * initial version * fixes for schema object, still cant get error handling to work correctly as well as tags * initial commit for transaction request service with the updated validation library using openapi-backend * updated to use central-services-shared * updates to new libraries for error handling and central-services-shared * updated dependencies and audit issues * updated tests to support Openapi Backend Using default functions for Openapi Backend validationFail, notFound and methodNotAllowed Fix for metrics not working * standardising request object as req updated dependencies and added audit for production only and not devDependencies * request naming standards * removed comment * Requested changes as per @mdebarros updated dependencies * missing regex for accents for name * Fixes for python version CircleCi (#42) python version upgrade updated dependencies and audit issues * bump version Co-authored-by: Rajiv Mothilal <rajivmothilal@gmail.com>
* fix: method handling and forwarding url, add PUT U2F related test * test: PUT U2F case * fix: swagger for auto mocker * todo: need to fix mojaloop_simulator * fix(package): add uuid4, update, bump version * refactor: use switch instead of if/else chain
* Poc/validation for names places accents (#37) * initial version * fixes for schema object, still cant get error handling to work correctly as well as tags * initial commit for transaction request service with the updated validation library using openapi-backend * updated to use central-services-shared * updates to new libraries for error handling and central-services-shared * updated dependencies and audit issues * updated tests to support Openapi Backend Using default functions for Openapi Backend validationFail, notFound and methodNotAllowed Fix for metrics not working * standardising request object as req updated dependencies and added audit for production only and not devDependencies * request naming standards * removed comment * Requested changes as per @mdebarros updated dependencies * missing regex for accents for name * Fixes for python version CircleCi (#42) python version upgrade updated dependencies and audit issues * lint: add proper indentation rule for switch * refactor: schema to work properly with hapi/open-api validation * feat: PUT authorization extended validation for oneOf schemas * chore: regenerate package-lock.json to fix vulnerability check * fix: use anyOf instead of oneOf Co-authored-by: Rajiv Mothilal <rajivmothilal@gmail.com>
* chore(circle): handle `-pisp` tag to build dedicated image * chore: bump version and setup simpler `pisp` tag filters * ci: allow tags with semver version perfix * chore: bump version * ci: fix filter regexp * chore: bump version * chore(package.json): don't bump version for pisp until ready * ci: checkout after installing dependencies * ci: try to fix lack of python in image-scan * ci: add anchore related deps in image-scan * ci: use python3 as dep for awsCli * ci: pip3 for awsCli * ci: drop apk purge for awsCli * ci: add python3-pip dep to awsCli * ci: use python3 -m pip * ci: add python3-dev dep * ci: fix typo * ci: py3-pip dep * ci: fix filter for deploy branch & update deps & bump version
* Poc/validation for names places accents (#37) * initial version * fixes for schema object, still cant get error handling to work correctly as well as tags * initial commit for transaction request service with the updated validation library using openapi-backend * updated to use central-services-shared * updates to new libraries for error handling and central-services-shared * updated dependencies and audit issues * updated tests to support Openapi Backend Using default functions for Openapi Backend validationFail, notFound and methodNotAllowed Fix for metrics not working * standardising request object as req updated dependencies and added audit for production only and not devDependencies * request naming standards * removed comment * Requested changes as per @mdebarros updated dependencies * missing regex for accents for name * Fixes for python version CircleCi (#42) python version upgrade updated dependencies and audit issues * fix: make accept header required only for GET /authorizations/{id} (#49) * fix: make accept header required only for GET /authorizations/{id} operation * chore: audit:resolve * chore: bump version * Update FSPIOP API version, dependencies, and package version (#52) * updated shared lib to support configurable resource api versions (#53) * added old joi to support hapi-swagger plugin * cleared unused dependencies Co-authored-by: Valentin <valentin.genev@modusbox.com> * updated shared lib version (#54) Co-authored-by: Valentin <valentin.genev@modusbox.com> * updated dependencies for helm release (#55) * #1876: Replace wildcard routes with explicit routes (#56) * Replace wildcard routes with explicit routes * Add uni tests for routes file * #1887-PUTauthorizationstransactionIdisnotvalidatingFSPIOPHeaders (#57) ### Hotfix: - Fixes to OpenAPI v3 specification document: - Changed all params to references - Updated all schemas to references - Added missing params - Fixed quotation characters, i.e. `”` -> `"` - Resolved bug mojaloop/project#1887 ### Maintenance: - Removed Swagger v2 interface specification, re-moved Swagger tools that only support Swagger v2. The code is now fully dependent on the OpenAPI v3 Spec document. I.e. only one spec doc \:D/ - Refactored existing code/unit-tests to work with OpenAPI v3 API specifications - Added OpenAPI v3 request generator as helper util - Cleaned-up unused dependencies in code - Cleaned-up unused dependencies/scripts in package.json - Updated dependencies to latest versions * chore: update license file (#58) * chore: migrate mock and openapi to work with latest * chore: upgrade packages and fix vulnerablilities * chore: fix packages * chore: fix tests * chore: update openapi and mockgen * chore: fix merge mishaps * chore: edit require statements * refactor: change routes handler * chore: change logic Co-authored-by: Rajiv Mothilal <rajivmothilal@gmail.com> Co-authored-by: eoln <2881004+eoln@users.noreply.github.com> Co-authored-by: Steven Oderayi <oderayi@gmail.com> Co-authored-by: Valentin Genev <vgenev@gmail.com> Co-authored-by: Valentin <valentin.genev@modusbox.com> Co-authored-by: Miguel de Barros <miguel@debarros.me> Co-authored-by: Lewis Daly <lewis@vesselstech.com>
eoln
requested review from
vgenev,
mdebarros,
elnyry-sam-k,
lewisdaly,
oderayi,
shashi165 and
vijayg10
as code owners
July 14, 2022 14:11
Quality Gate failedFailed conditions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge & delete this PR
It is used to track changes from master to pisp/master branch