fixing errors and removing lidoscript

test/test_file.py

@@ -1,9 +1,9 @@
 from pathlib import Path
-from zml2lido.file import per_chunk, unzip
+from zml2lido.file import per_chunk
 
 
 def test_per_chunk():
     p = Path(r"C:\m3\zml2lido\sdata\GG\20240307\query516069-chunk1.lido.xml")
     if not p.exists():
-        raise FileNotFound("p not found!")
+        raise FileNotFoundError("p not found!")
     assert 2 == len(list(per_chunk(p)))

zml2lido/__init__.py

@@ -8,7 +8,6 @@
 
 
 import argparse
-import sys
 from zml2lido.lidoTool import LidoTool
 from zml2lido.linkChecker import LinkChecker
 from zml2lido.vocmap import Vocmap

zml2lido/lidoTool.py

@@ -33,8 +33,7 @@
 import os
 import re
 import subprocess
-import sys
-from typing import Iterable, Optional
+from typing import Iterable
 from zipfile import ZipFile
 from zml2lido.linkChecker import LinkChecker
 
@@ -102,7 +101,7 @@ def execute(self, job: str) -> None:
             raise SyntaxError("ERROR: Unknown job name!")
 
     def lfilter(self, *, split: bool = False, Type: str) -> None:
-        if not Type in xsl:
+        if Type not in xsl:
             raise TypeError(f"Error: Unknown type '{Type}'")
 
         new_fn = self.src.stem + f"-no{Type}.xml"
@@ -315,7 +314,7 @@ def saxon(self, *, src: str | Path, output: str | Path, xsl: str | Path) -> None
             raise SyntaxError(f"ERROR: src {src} does not exist!")
 
         if not Path(xsl).exists():
-            raise SyntaxError(f"ERROR: xsl file does not exist!")
+            raise SyntaxError("ERROR: xsl file does not exist!")
 
         cmd = f"java -Xmx1450m -jar {saxLib} -s:{src} -xsl:{xsl} -o:{output}"
         print(cmd)
@@ -399,7 +398,7 @@ def _sanitize(self, *, src: str | Path) -> Path:
 
         if not Path(saxLib).is_file():
             raise SyntaxError(
-                f"ERROR: Saxon not found, check environment variable saxLib"
+                "ERROR: Saxon not found, check environment variable saxLib"
             )
 
         # check src

zml2lido/linkChecker.py

@@ -22,10 +22,7 @@
 from lxml import etree
 from mpapi.constants import get_credentials
 from mpapi.client import MpApi
-from mpapi.module import Module
-from mpapi.search import Search
 from pathlib import Path
-import re
 from typing import Any
 import urllib.request
 from zml2lido.relWorksCache import RelWorksCache

zml2lido/qc.py

@@ -9,7 +9,6 @@
 """
 
 import argparse
-from pathlib import Path
 
 parser = argparse.ArgumentParser(description="Quality control for LIDO files")
 parser.add_argument(

zml2lido/vocmap.py

@@ -7,7 +7,7 @@
 
 """
 from lxml import etree
-from openpyxl import Workbook, load_workbook
+from openpyxl import Workbook
 from openpyxl.styles import Font
 from pathlib import Path