-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Packageify & Migrate to Py3 #17
Open
Adamtaranto
wants to merge
35
commits into
molbio-dresden:master
Choose a base branch
from
Adamtaranto:packageify
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate module to modern scientific python package format
Hi All, thanks for producing this tool! I've found it super useful in my work. I've done a bit of refactoring here to improve usability in modern python envs.
This PR restructures Flexidot as a pip installable, Py3 compatible, package.
When merged this will support distribution via PyPi and Bioconda.
Versioning is now controlled via git tags.
Several cmd line args have been modified to simplify handling with argparse. Next release should bump up a major version to v2.0.0 to signal that it is not backwards compatible.
Compatibility issues
find_match_pos_diag()
Closes numpy version #15Refactor and Modernise package structure
Improve user experience
Automation
Testing
find_match_pos_diag()
is correct