Design Audit Feedback (April 2024)

[KastanDay]

I'm addressing the round of feedback here: https://www.figma.com/file/P9nzk24NcOppCZ3GcggQ3B/ChemScraper?type=design&node-id=3108-417&mode=design&t=maCpycthbMv4eYSs-0

[KastanDay]

I added error handling for failed analysis jobs. At least now we see the 404, or whatever error text, instead of staring at an infinite spinner.

[KastanDay]

Final nits:

• Revised copy on Expanded MoleculeRow
  • Show image of structure instead of chemical formula in Expanded MoleculeRow (but this is redundant info, so non critical)
  • PubChem ID (already exists) but add auto-link to PubChem page.

[KastanDay]

@matthewberry and @bodom0015 this PR is ready for review and merge.

It's deployed to staging.

I've tested it thoroughly and strongly believe it's all working great.

It addresses 99% of the design audit feedback, all the major notes. It's just missing tiny details in spacing, layout & beauty.

Final nits:

• Revised copy on Expanded MoleculeRow
  • Show image of structure instead of chemical formula in Expanded MoleculeRow (but this is redundant info, so non critical)
  • PubChem ID (already exists) but add auto-link to PubChem page.
• Maximum of single toast (instead of multiple) when "no results found" when searching on results table.
• On job error, show proper error page instead of a toast popup.

[bodom0015]

LGTM 👍 deployed this to staging (#102 was running instead)
after re-testing with the Grenning PDF, everything seems to work very well 🎉

Thanks again, @KastanDay! :)