-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: workaround for error in getByJobTypeAndJobIdAndRunId #102
Conversation
…ag and Similarity
…Not sure flagging works tho!
…SMILES. Add MarvinJS logo
…call for similarity
In testing, after uploading a file the button "Analyze with Chemscraper" remains disabled, so I can't submit the job. Same with the example pdf. The network tab shows the Upload responds with 200.
|
…leculemaker/chemscraper-frontend into bugfix/fix-file-paths-and-result-fetch
…leculemaker/chemscraper-frontend into bugfix/fix-file-paths-and-result-fetch
Thank you, @KastanDay! I think you fixed this issue in the base branch, so it should be fixed here as well 👍 Is it ok that we are merging this into Do you have any preference here? |
@bodom0015 No preference! Go for main, then it's nice and independent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested with a random chemistry PDF, it worked great. Approved, recommend merge.
I tested again today with both the Example PDF and a random chem PDF, still working great. Merging. |
Problem
Frontend has trouble fetching job results after adding Kubernetes job support
Approach
getByJobTypeAndJobId
instead - we can simply assume a single run for nowHow to Test
Test this with moleculemaker/mmli-backend#43
Currently deployed on prod: https://chemscraper.platform.moleculemaker.org