-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/s3 publshing #12
Closed
Closed
Fix/s3 publshing #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new configuration setting: AzurePublishEndpoints, similar to the existing S3PublishEndpoints and SwiftPublishEndpoints. For each endpoint, the following has to be defined: - accountName - accountKey - container - prefix Azure tests require the following environment variables to be set: - AZURE_STORAGE_ACCOUNT - AZURE_STORAGE_ACCESS_KEY With either of these not set, Azure-specific tests are skipped.
Co-authored-by: Andrej Shadura <andrew@shadura.me>
Signed-off-by: Andrej Shadura <andrew.shadura@collabora.co.uk>
this is needed so concurrent reads and writes are possible.
This way db usage is safe.
Progress is not safe so for api its always nil and code needs to take care of this
This should avoid deadlocking when context is destroyed.
each key needs to be provided as separate argument to gpg1 --recv-keys
For read-only action transactions are not necessary and they risk to deadlock if multiple go-routines try to read the database.
When trying to delete a mirror that has snapshot and not providing the force option, the API should not return a `500 StatusInternalServerError`. A `403 StatusForbidden` is more appropriate when the condition is expected by the server.
Updated the repo key, repo links in tests (jessie-cran35 -> bullseye-cran40) and the expected test output. Fixes: #1218
The current regex runs in exponential time, which massively impacts the runtime of the test suite, taking several seconds (~4s on my system) just to perform a single match. By replacing the mix of re.findall + the initial capture group with re.search + some string slicing, the time spent matching the regex becomes nearly instant, e.g.: $ make system-test TESTS='Config*' goes from taking ~10s to ~1.5s. Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
1.20 changes the output format of coverage checks slightly to include a package name on each line, followed by `coverage:`, but the current regex assumes that the line *starts* with `coverage:`. Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
This will properly close the db and, more particularly, flush out any profile files being written. Otherwise, they can end up empty or truncated. Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.15.0 to 0.17.0. - [Commits](golang/net@v0.15.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
as per contributor instructions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: aptly-dev/aptly#1241