From ecc0e27c100f228d9fbc22366384ee5ebb06d73b Mon Sep 17 00:00:00 2001 From: "Kevin R. Thornton" Date: Wed, 16 Aug 2023 15:43:17 -0700 Subject: [PATCH] bump pybind11 to 2.11.1 (#1172) * bump pybind11 to 2.11.1 * Bump minimum cmake to 3.27 * Bump pybind11 version in root CMakeLists.txt * Remove unused define from cmake_args in setup.py * minor updates to Python build files --- CMakeLists.txt | 6 +++--- pyproject.toml | 8 +++++++- requirements/conda_minimal_deps.txt | 2 +- requirements/development.txt | 2 +- setup.cfg | 1 - setup.py | 2 -- 6 files changed, 12 insertions(+), 9 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index e43ddbd1dc..2a553b54fe 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1,4 +1,4 @@ -cmake_minimum_required(VERSION 3.15) +cmake_minimum_required(VERSION 3.27) project(fwdpy11) set(CMAKE_CXX_EXTENSIONS OFF) @@ -15,8 +15,8 @@ endif() find_package(pybind11) message(STATUS "Found pybind11: ${pybind11_VERSION}") -if(${pybind11_VERSION} VERSION_LESS '2.10.0') - message(FATAL_ERROR "pybind11 version must be >= '2.10.0'") +if(${pybind11_VERSION} VERSION_LESS '2.11.1') + message(FATAL_ERROR "pybind11 version must be >= '2.11.1'") endif() add_definitions(-DPYBIND11_VERSION="${pybind11_VERSION}") diff --git a/pyproject.toml b/pyproject.toml index 8c55e08f68..eed7dc28b3 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -1,6 +1,12 @@ [build-system] # We need setup.cfg support, which setuptools indtroduced in 30.3.0. -requires = ["setuptools>=30.3.0", "wheel", "setuptools_scm", "pybind11[global]==2.10.0"] +requires = [ + "setuptools>=30.3.0", + "wheel", + "setuptools_scm", + "pybind11[global]==2.11.1", +] +build-backend = "setuptools.build_meta" [tool.setuptools_scm] write_to = "fwdpy11/_version.py" diff --git a/requirements/conda_minimal_deps.txt b/requirements/conda_minimal_deps.txt index c4b7b57516..44d998db45 100644 --- a/requirements/conda_minimal_deps.txt +++ b/requirements/conda_minimal_deps.txt @@ -1,5 +1,5 @@ intervaltree -pybind11==2.10.0 +pybind11==2.11.1 numpy scipy attrs>=0.19.2 diff --git a/requirements/development.txt b/requirements/development.txt index 975f9ba4f8..c3b3c259c1 100644 --- a/requirements/development.txt +++ b/requirements/development.txt @@ -1,7 +1,7 @@ # NOTE: any pinning should also be coordinated # with requirements.in and doc/requirements.in # and may require regenerating the .txt files. -pybind11[global]==2.10.0 +pybind11[global]==2.11.1 intervaltree numpy scipy diff --git a/setup.cfg b/setup.cfg index efa07ef346..3939d79f4c 100644 --- a/setup.cfg +++ b/setup.cfg @@ -13,7 +13,6 @@ classifiers = License :: OSI Approved :: GNU General Public License v3 or later (GPLv3+) [options] -packages = fwdpy11 zip_safe = False # https://mypy.readthedocs.io/en/latest/installed_packages.html include_package_data = True python_requires = >=3.8, <3.12 diff --git a/setup.py b/setup.py index d1b36566d7..91edbae6ce 100644 --- a/setup.py +++ b/setup.py @@ -78,7 +78,6 @@ def build_extension(self, ext): cmake_args = [ "-DCMAKE_LIBRARY_OUTPUT_DIRECTORY=" + extdir, "-DCMAKE_ARCHIVE_OUTPUT_DIRECTORY=" + parent + "/lib/", - "-DPYTHON_EXECUTABLE=" + sys.executable, "-DCMAKE_BUILD=OFF", ] @@ -186,5 +185,4 @@ def build_extension(self, ext): cmdclass={"build_ext": CMakeBuild}, packages=PKGS, package_data=generated_package_data, - zip_safe=False, )