Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timing of genetic value calculation vs fixation removal #1325

Open
molpopgen opened this issue Jul 17, 2024 · 1 comment
Open

Timing of genetic value calculation vs fixation removal #1325

molpopgen opened this issue Jul 17, 2024 · 1 comment

Comments

@molpopgen
Copy link
Owner

PR #1324 fixed an issue where fixations were not being "pruned" even when that option was True.

With that fix, though, we have the following behaviors:

  • genetic values are calculated BEFORE and fixation pruning
  • Therefore, fixations are part of the genetic value calculation!!
    Including them is the right thing to do for additive model and is
    "fine" for multiplicative models b/c the way we choose parents
    only requires that we know relative fitnesses.
  • However, certain operations may be annoying.
    For example, tracking mean fitness over time in "standard pop gen" scenarios
    requires correcting values stored in metadata by the effect sizes
    of fixations that generation.
    (This situation is even more obnoxious when we are not tracking
    counts each generation -- fixations since the last simplification
    accumulate.)

Ultimately, these issues are all due to fwpdy11 being written to simulate
traits and all the "pop gen" stuff is bolted on top.

It may be possible to move the order of when genetic values are calculated
to AFTER fixation removal.
Dealing with the simplification issue described above is harder -- we don't necessarily
know the counts.

@molpopgen
Copy link
Owner Author

Quick experimentation changing the order of events results in most tests passing but the sweep tests seem to loop forever, implying that how we are monitoring for fixations is depending on the mutations being found in genomes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant