Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build using numpy 2 #1318

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Build using numpy 2 #1318

merged 1 commit into from
Jul 9, 2024

Conversation

molpopgen
Copy link
Owner

  • depend on numpy >= 2
  • follow what tskit does

@molpopgen
Copy link
Owner Author

We can't make progress until we have an msprime release supporting numpy 2. See tskit-dev/msprime#2286 and tskit-dev/msprime#2287

We also need to decide what to do re: supporting numpy 1.x and 2 at the same time or just jumping to 2.x only.

@benjeffery
Copy link

We can't make progress until we have an msprime release supporting numpy 2. See tskit-dev/msprime#2286 and tskit-dev/msprime#2287

We also need to decide what to do re: supporting numpy 1.x and 2 at the same time or just jumping to 2.x only.

Working on those today.
We are supporting both - it seems binaries compiled with 2 can be used by recent versions of 1.XX.

@molpopgen
Copy link
Owner Author

We can't make progress until we have an msprime release supporting numpy 2. See tskit-dev/msprime#2286 and tskit-dev/msprime#2287
We also need to decide what to do re: supporting numpy 1.x and 2 at the same time or just jumping to 2.x only.

Working on those today. We are supporting both - it seems binaries compiled with 2 can be used by recent versions of 1.XX.

I (believe that I) am installing numpy >= 2 for all tasks in this PR, which is the likely problem. I need to do some homework re: compiling to support both in a module generated using pybind11.

* bump msprime version used in CI
@molpopgen molpopgen enabled auto-merge (squash) July 9, 2024 18:55
@molpopgen molpopgen merged commit b064ab8 into dev Jul 9, 2024
34 checks passed
@molpopgen molpopgen deleted the numpy_2 branch July 9, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants