Improve runtime safety when building lookup tables #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molpopgen
force-pushed
the
cpp_gsl_tests
branch
3 times, most recently
from
01d54c7
to
8665904
Compare
* Add internal API to disallow weight vectors of all zeros. * Apply the new API to internal code. * Use GlobalExtinction exception when all diploid fitness values are zero. * Use new LocalExtinction exception when all fitnesses in a deme are zero. * Add new Python and C++ tests.
molpopgen
force-pushed
the
cpp_gsl_tests
branch
from
6963861
to
02afff5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GSL discrete lookup table happily accepts all weights being 0.
When the weights are fitness, this behavior is a pathology: a zombie
population reverts to one that is happily all neutral.
This PR fixes that behavior and will also do more thorough checking
in other places where this type is used.