fix: google-protobuf as dependency (#11)

momentohq · Oct 14, 2021 · 43dc5f8 · 43dc5f8
1 parent 15361eb
commit 43dc5f8
Show file tree

Hide file tree

Showing 5 changed files with 132 additions and 5 deletions.
diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml
@@ -29,7 +29,7 @@ jobs:
           set -x
           export PATH=`pwd`/protoc/bin/:$PATH
           pushd typescript
-            npm install
+            npm ci
             npm run build
           popd
         shell: bash
diff --git a/.github/workflows/push.yml b/.github/workflows/push.yml
@@ -35,7 +35,7 @@ jobs:
           set -x
           export PATH=`pwd`/protoc/bin/:$PATH
           pushd typescript
-            npm install
+            npm ci
             npm run build
           popd
         shell: bash

diff --git a/typescript/.gitignore b/typescript/.gitignore
@@ -1,5 +1,4 @@
 node_modules
 dist
-package-lock.json
 **/*.d.ts
 index.js
diff --git a/typescript/package-lock.json b/typescript/package-lock.json
diff --git a/typescript/package.json b/typescript/package.json
@@ -11,13 +11,13 @@
   "license": "MIT",
   "devDependencies": {
     "@tsconfig/node16": "1.0.2",
-    "@types/google-protobuf": "3.15.5",
     "@types/node": "16.10.3",
-    "google-protobuf": "3.18.1",
     "protoc-gen-ts": "0.6.0",
     "typescript": "4.4.3"
   },
   "dependencies": {
+    "@types/google-protobuf": "3.15.5",
+    "google-protobuf": "3.18.1",
     "@grpc/grpc-js": "1.3.7"
   },
   "files": [