Skip to content

Commit

Permalink
chore: remove vectordb protos
Browse files Browse the repository at this point in the history
  • Loading branch information
ben-kugler committed Jun 13, 2024
1 parent be4d013 commit f386b15
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 273 deletions.
1 change: 0 additions & 1 deletion javascript-web/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ export * as cache from './CacheclientServiceClientPb'
export * as control from './ControlclientServiceClientPb'
export * as auth from './AuthServiceClientPb'
export * as token from './TokenServiceClientPb'
export * as vectorindex from './VectorindexServiceClientPb'
export * as ping from './CachepingServiceClientPb'
export * as leaderboard from './LeaderboardServiceClientPb'
export * as webhook from './WebhookServiceClientPb'
Expand Down
2 changes: 1 addition & 1 deletion javascript/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
```bash
npm install
mkdir dist
PATH=node_modules/protoc-gen-ts/bin/:$PATH protoc -I=../proto --ts_out=dist cacheclient.proto controlclient.proto cachepubsub.proto vectorindex.proto
PATH=node_modules/protoc-gen-ts/bin/:$PATH protoc -I=../proto --ts_out=dist cacheclient.proto controlclient.proto cachepubsub.proto
```
2 changes: 1 addition & 1 deletion javascript/generate_protos.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ set -x
# tricky to build on mac. This issue showed what I believe is the "official" way to do it now... question mark?
# https://github.com/protocolbuffers/protobuf/pull/9874#issuecomment-1481023982
#
npx grpc_tools_node_protoc -I=../proto -I=/usr/local/include --ts_out=src permissionmessages.proto cacheclient.proto controlclient.proto cachepubsub.proto auth.proto cacheping.proto vectorindex.proto token.proto leaderboard.proto webhook.proto store.proto
npx grpc_tools_node_protoc -I=../proto -I=/usr/local/include --ts_out=src permissionmessages.proto cacheclient.proto controlclient.proto cachepubsub.proto auth.proto cacheping.proto token.proto leaderboard.proto webhook.proto store.proto
267 changes: 0 additions & 267 deletions proto/vectorindex.proto

This file was deleted.

2 changes: 1 addition & 1 deletion python/run-protoc.sh
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ do
if [[ $python_protobuf_version == "protobuf>4" ]]; then
pyi_out="--pyi_out=$src_path"
fi
poetry run python -m grpc_tools.protoc -I../proto --python_out=$src_path $pyi_out --grpc_python_out=$src_path permissionmessages.proto extensions.proto cacheclient.proto controlclient.proto auth.proto cachepubsub.proto vectorindex.proto token.proto
poetry run python -m grpc_tools.protoc -I../proto --python_out=$src_path $pyi_out --grpc_python_out=$src_path permissionmessages.proto extensions.proto cacheclient.proto controlclient.proto auth.proto cachepubsub.proto token.proto

# A shortcoming of the generated code is in the grpc generated code,
# the protobuf imports are absolute instead of relative.
Expand Down
5 changes: 3 additions & 2 deletions rust/proto_generator/build.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ fn main() {
eprintln!("Hi brave developer! If you are changing protos and momento-protos fails to build, please retry 1 time.");
eprintln!("Cargo currently does not have a nice way for us to express a dependency order between these 2");
eprintln!("workspace projects - because this project is _specifically_ supposed to not be a Cargo dependency.");
eprintln!("We did this so downstream users don't need to have protoc when compiling momento-protos!");
eprintln!(
"We did this so downstream users don't need to have protoc when compiling momento-protos!"
);

eprintln!("If you are finding that your builds work locally, but not in CI, then you need to manual cleanup some artifacts");
eprintln!("Clear out the `momento-protos/src` of all protos besides lib.rs, then run `cargo clean` and `cargo build`.");
Expand All @@ -24,7 +26,6 @@ fn main() {
format!("{proto_dir}/cacheclient.proto"),
format!("{proto_dir}/cachepubsub.proto"),
format!("{proto_dir}/controlclient.proto"),
format!("{proto_dir}/vectorindex.proto"),
format!("{proto_dir}/store.proto"),
],
&[proto_dir],
Expand Down

0 comments on commit f386b15

Please sign in to comment.