feat: add account session token API #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlinehan
reviewed
Jun 24, 2024
| @@ -23,3 +24,11 @@ message _Account { | |||
| string id = 1; | |||
| string account_name = 2; | |||
| } | |||
|
|
|||
| message _GetAccountSessionTokenRequest { | |||
| string account_id = 1; | |||
There was a problem hiding this comment.
The customer id/subject will be in the auth context, right, because it'll be from the auth0 token? Are we planning on using the user id at all? Or not yet?
There was a problem hiding this comment.
The Auth0 token establishes the user - the flow is that the console will first call the "GetAccounts" API to get a list of accounts, then pass back the user's selection via this API to generate an auth token scoped to that account.
rlinehan
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new global API, used for generating account-scoped session tokens.