Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate better handling of h2 goaway for grpc stream handlers #156

Open
eaddingtonwhite opened this issue Feb 22, 2023 · 0 comments
Open

Comments

@eaddingtonwhite
Copy link
Member

Currently for topics we are handling h2 goaway in a grpc stream by handling grpc unavailable error that's returned by go grpc in this scenario. This is not ideal though ideally this should be handled at a lower level so could do something like this in golang would be more robust:

	if e, ok := err.(http2.GoAwayError); ok {
		if e.ErrCode == http2.ErrCodeNo {
			fmt.Println(fmt.Sprintf("got goaway error %+v", e))
		}
	}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant