Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add golangci-lint to make lint #238

Open
2 tasks
schwern opened this issue Mar 6, 2023 · 0 comments
Open
2 tasks

Add golangci-lint to make lint #238

schwern opened this issue Mar 6, 2023 · 0 comments
Labels
chore

Comments

@schwern
Copy link
Contributor

schwern commented Mar 6, 2023

The Github action has an additional lint step, golangci-lint. This is not currently part of make lint, so sometimes make lint passes yet CI fails.

  • Add golangci-lint to make lint.
  • If possible, add it to make install-devtools.
    • Install instructions.
    • They recommend binary installation, which complicates things, but there is a go install option.
@schwern schwern added the chore label Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@schwern