chore: copy protos for new APIs to go sdk and fix MakeFile #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cprice404
reviewed
Jul 5, 2023
There was a problem hiding this comment.
I will hold off on weighing in on this until @eaddingtonwhite and @pgautier404 do, they will have more context than I do.
pgautier404
reviewed
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated MakeFile to provide the protoc path as
internal/protosrather thaninternal. This fixed the problem of generating the proto files that was mentioned on the issue linked to this PR. However, there are certain changes I wanted to call out due to which one of our CIs is also failing:protocwants the directory that contains all the.protofiles andinternal/protosis the correct one for both reading the input files and generating the output ones.protos_auth_prototoauth_protowhose format takes the directory structure. Since we toldprotocto take files from internal/protos rather than internal only, all those source changes have been reflected either insourcefield or the variable/method names.Verify no changes from goimports and go mod tidyfails because some of the imports were reordered as a part of this update to the input and output directories. Note that the protoc version was also bumped from3.20.3to4.23.3We should really invest some time in this #333 as well and am going to do some digging once I have some time off my tasks.
None of this seem breaking to me but I'm not 100% so we can discuss over a call as well.