Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: copy protos for new APIs to go sdk and fix MakeFile #332

Merged
merged 4 commits into from
Jul 5, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,15 @@ jobs:
only-new-issues: true
skip-pkg-cache: true

- name: Build
run: make build

- name: Build examples
run: make build-examples

- name: Run test
run: make test

pgautier404 marked this conversation as resolved.
Show resolved Hide resolved
# If there are any diffs from goimports or go mod tidy, fail.
- name: Verify no changes from goimports and go mod tidy
run: |
Expand All @@ -50,11 +59,4 @@ jobs:
exit 1
fi

- name: Build
run: make build

- name: Build examples
run: make build-examples

- name: Run test
run: make test
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ protos:
@echo "Did you copy momentohq/client_protos/protos/*.proto to internal/protos?"
# this file is not needed and causes errors, so make sure it's not present
rm -f internal/protos/httpcache.proto
protoc -I=internal --go_out=internal --go_opt=paths=source_relative --go-grpc_out=internal --go-grpc_opt=paths=source_relative internal/protos/*.proto
protoc -I=internal/protos --go_out=internal/protos --go_opt=paths=source_relative --go-grpc_out=internal/protos --go-grpc_opt=paths=source_relative internal/protos/*.proto

.PHONY: build
build:
Expand Down
Loading
Loading