feat: support topic sequence page #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the topic subscription to take the sequence page into account: - Keeps track of last known sequence page in addition to sequence number so we can reconnect gracefully - Includes sequence page detail for topic item and discontinuity objects
Previously a user could have set the sequence number in a subscribe request and it would have been ignored. We pass it along here though provide no guidance on how to set it; ie users should leave it unset, but when they do set it, we should respect it.
|
Opening for early review. Once the service is live, I will update the protos and rebase. |
anitarua
reviewed
Oct 8, 2024
|
Ready for final review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates the protos selectively to include the topic sequence page changes from this PR on the client protos repo. In the future we will update to the released protos.
There are two changes: the topic subscription logic and the topic subscribe logic.
Topic Subscription changes
Updates the topic subscription to take the sequence page into account:
Topic Subscribe changes
Previously the topic client
Subscribemethod took aTopicSubscriptionas input but ignored the resume at sequence number. While the sequence number was used internally on reconnects and not expected to be used externally, we feel it could be confusing if a user sets the sequence number and we ignore it.Since we also add the sequence page, we also pass that to the subscribe RPC.
To test/confirm once service is live