From c8c9e5726b796e621ca238423622f7f7eb0d0209 Mon Sep 17 00:00:00 2001 From: Michael Landis Date: Tue, 9 Jul 2024 13:17:56 -0700 Subject: [PATCH] ci: read from momento api key (#382) In order to be uniform with other SDKs, we read the API key from the environment variable MOMENTO_API_KEY. --- .github/workflows/ci.yml | 2 -- .github/workflows/codeql.yml | 3 +-- .../src/intTest/java/momento/sdk/BaseCacheTestClass.java | 2 +- .../src/intTest/java/momento/sdk/BaseStorageTestClass.java | 2 +- 4 files changed, 3 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 283bf7ab..d6d5805a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -8,9 +8,7 @@ jobs: build: runs-on: ubuntu-latest env: - TEST_AUTH_TOKEN: ${{ secrets.ALPHA_TEST_AUTH_TOKEN }} MOMENTO_API_KEY: ${{ secrets.ALPHA_TEST_AUTH_TOKEN }} - TEST_CACHE_NAME: java-integration-test-ci-${{ github.sha }} steps: - name: Checkout project diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml index dcb49030..e1da4de8 100644 --- a/.github/workflows/codeql.yml +++ b/.github/workflows/codeql.yml @@ -26,8 +26,7 @@ jobs: runs-on: ubuntu-latest env: - TEST_AUTH_TOKEN: ${{ secrets.ALPHA_TEST_AUTH_TOKEN }} - TEST_CACHE_NAME: dummy + MOMENTO_API_KEY: ${{ secrets.ALPHA_TEST_AUTH_TOKEN }} permissions: actions: read diff --git a/momento-sdk/src/intTest/java/momento/sdk/BaseCacheTestClass.java b/momento-sdk/src/intTest/java/momento/sdk/BaseCacheTestClass.java index 76209592..9bacd561 100644 --- a/momento-sdk/src/intTest/java/momento/sdk/BaseCacheTestClass.java +++ b/momento-sdk/src/intTest/java/momento/sdk/BaseCacheTestClass.java @@ -19,7 +19,7 @@ public class BaseCacheTestClass { @BeforeAll static void beforeAll() { - credentialProvider = CredentialProvider.fromEnvVar("TEST_AUTH_TOKEN"); + credentialProvider = CredentialProvider.fromEnvVar("MOMENTO_API_KEY"); cacheClient = CacheClient.builder(credentialProvider, Configurations.Laptop.latest(), DEFAULT_TTL_SECONDS) .build(); diff --git a/momento-sdk/src/intTest/java/momento/sdk/BaseStorageTestClass.java b/momento-sdk/src/intTest/java/momento/sdk/BaseStorageTestClass.java index 1172da5d..9fd6ff28 100644 --- a/momento-sdk/src/intTest/java/momento/sdk/BaseStorageTestClass.java +++ b/momento-sdk/src/intTest/java/momento/sdk/BaseStorageTestClass.java @@ -17,7 +17,7 @@ public class BaseStorageTestClass { @BeforeAll static void beforeAll() { - credentialProvider = CredentialProvider.fromEnvVar("TEST_AUTH_TOKEN"); + credentialProvider = CredentialProvider.fromEnvVar("MOMENTO_API_KEY"); storageClient = new PreviewStorageClientBuilder() .withCredentialProvider(credentialProvider)