Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: storage SDK orElseThrow should take a supplier #383

Merged
merged 1 commit into from
Jul 10, 2024
Merged

fix: storage SDK orElseThrow should take a supplier #383

merged 1 commit into from
Jul 10, 2024

Commits on Jul 10, 2024

  1. fix: storage SDK orElseThrow should take a supplier 

    The `orElseThrow` signature of Java Optionals requires a single
arg, `supplier`, that is a lambda function returning the exception
that the user wishes to have thrown if the optional is empty.
In our current storage client code we have an empty-args signature,
which would be surprising to Java users familiar with Optionals.
This commit updates the signature to accept a supplier.
    @cprice404
    cprice404 committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    528b91f View commit details
    Browse the repository at this point in the history