Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add docs examples for PreviewStorageClient #384

Merged
merged 15 commits into from
Jul 11, 2024

Conversation

cprice404
Copy link
Contributor

No description provided.

@cprice404 cprice404 requested review from malandis and a team July 10, 2024 22:23
@@ -95,7 +95,7 @@ public static void example_API_CreateCache(CacheClient cacheClient) {
if (response instanceof CacheCreateResponse.Success) {
System.out.println("Cache 'test-cache' created");
} else if (response instanceof CacheCreateResponse.Error error) {
if (error.getCause() instanceof AlreadyExistsException) {
if (error.getErrorCode() == MomentoErrorCode.ALREADY_EXISTS_ERROR) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This SDK doesn't have the this as an alternative for the create cache response unfortunately.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, i noticed that. I kind of want to fix that right now, do you have any opinion on it?

@cprice404 cprice404 merged commit 95a7765 into main Jul 11, 2024
5 checks passed
@cprice404 cprice404 deleted the example-snippets-for-storage branch July 11, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants