Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix list fetch end index description #387

Merged
merged 5 commits into from
Sep 3, 2024

Conversation

malandis
Copy link
Contributor

Corrects the end index documentation on listFetch to indicate it is
exclusive, not inclusive.

Corrects the end index documentation on `listFetch` to indicate it is
exclusive, not inclusive.
@malandis malandis requested review from nand4011, rishtigupta and a team August 30, 2024 20:20
nand4011
nand4011 previously approved these changes Aug 30, 2024
@@ -1668,7 +1668,7 @@ public CompletableFuture<ListConcatenateFrontResponse> listConcatenateFrontByteA
* @param cacheName The cache containing the list.
* @param listName The list to fetch.
* @param startIndex Start index (inclusive) for fetch operation. Defaults to 0 if not provided.
* @param endIndex End index (inclusive) for fetch operation. Defaults to the end of the list if
* @param endIndex End index (exclusive) for fetch operation. Defaults to the end of the list if
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose technically it should be

Suggested change
* @param endIndex End index (exclusive) for fetch operation. Defaults to the end of the list if
* @param endIndex End index (exclusive) for the fetch operation. Defaults to the end of the list if

@malandis malandis merged commit 87a6119 into main Sep 3, 2024
5 checks passed
@malandis malandis deleted the docs/adjust-list-fetch-docs branch September 3, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants