Skip to content

Commit

Permalink
No commit message
Browse files Browse the repository at this point in the history
  • Loading branch information
2 parents 2fc51ca + 016b5dd commit c726926
Show file tree
Hide file tree
Showing 48 changed files with 3,413 additions and 361 deletions.
1 change: 0 additions & 1 deletion .github/workflows/on-pull-request.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ jobs:

env:
TEST_AUTH_TOKEN: ${{ secrets.ALPHA_TEST_AUTH_TOKEN }}
TEST_CACHE_NAME: php-integration-test-cache

steps:
- uses: actions/checkout@v3
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/on-push-to-main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ jobs:
runs-on: ubuntu-latest
env:
TEST_AUTH_TOKEN: ${{ secrets.ALPHA_TEST_AUTH_TOKEN }}
TEST_CACHE_NAME: php-integration-test-cache

steps:
- uses: actions/checkout@v3
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/on-push-to-release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ jobs:
runs-on: ubuntu-latest
env:
TEST_AUTH_TOKEN: ${{ secrets.ALPHA_TEST_AUTH_TOKEN }}
TEST_CACHE_NAME: php-integration-test-cache

steps:
- uses: actions/checkout@v3
Expand Down
12 changes: 4 additions & 8 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,17 +1,14 @@
<img src="https://docs.momentohq.com/img/logo.svg" alt="logo" width="400"/>

# Welcome to client-sdk-php contributing guide :wave:
# Welcome to the PHP SDK Contributing Guide :wave:

Thank you for taking your time to contribute to our PHP SDK!
<br/>

This guide will provide you information to start your own development and testing.
<br/>

Happy coding :dancer:
<br/>

## Requirements

Check out our SDK [requirements](https://github.com/momentohq/client-sdk-php#requirements)!
Check out our PHP SDK documentation for [requirements](https://docs.momentohq.com/sdks/php#requirements)!

## Build Docker Image

Expand All @@ -25,6 +22,5 @@ You will likely need to run this only once:

```bash
export TEST_AUTH_TOKEN=<YOUR_AUTH_TOKEN>
export TEST_CACHE_NAME=<YOUR_CACHE_NAME>
./dev-run-integration-tests.sh
```
7 changes: 6 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,12 @@
"Cache_client\\": "types/Cache_client/",
"Control_client\\": "types/Control_client/",
"Auth\\": "types/Auth/",
"GPBMetadata\\": "types/GPBMetadata"
"GPBMetadata\\": "types/GPBMetadata/",
"Common\\": "types/Common/",
"Leaderboard\\": "types/Leaderboard/",
"Permission_messages\\": "types/Permission_messages/",
"Token\\": "types/Token/",
"Webhook\\": "types/Webhook/"
},
"files": [
"src/Utilities/_DataValidation.php"
Expand Down
11 changes: 1 addition & 10 deletions dev-run-integration-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -12,18 +12,9 @@ else
export TEST_AUTH_TOKEN=$TEST_AUTH_TOKEN
fi

if [ "$TEST_CACHE_NAME" == "" ]
then
echo "Missing required env var TEST_CACHE_NAME"
exit 1
else
export TEST_CACHE_NAME=$TEST_CACHE_NAME
fi

DOCKER_IMAGE_NAME=momento-php-dev

DOCKER_BASE_COMMAND="docker run -it -v$(pwd):/app -w=/app"
$DOCKER_BASE_COMMAND $DOCKER_IMAGE_NAME composer install
$DOCKER_BASE_COMMAND -e TEST_AUTH_TOKEN="$TEST_AUTH_TOKEN" -e TEST_CACHE_NAME="$TEST_CACHE_NAME" \
$DOCKER_BASE_COMMAND -e TEST_AUTH_TOKEN="$TEST_AUTH_TOKEN" \
$DOCKER_IMAGE_NAME php vendor/phpunit/phpunit/phpunit --configuration phpunit.xml

Loading

0 comments on commit c726926

Please sign in to comment.