Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report protocol buffer generation issue to Google #12

Open
1 of 3 tasks
schwern opened this issue Nov 3, 2022 · 4 comments
Open
1 of 3 tasks

Report protocol buffer generation issue to Google #12

schwern opened this issue Nov 3, 2022 · 4 comments
Labels
blocked bug 🐛 🐞 Something isn't working

Comments

@schwern
Copy link
Contributor

schwern commented Nov 3, 2022 •
edited
Loading

A protocol message with an underscore will not be translated correctly into Ruby. They're translated into constants, and constants with a leading underscore are private. They try to account for this by prepending PB_, but they still try to reference it without the prefix. 😮‍💨 🌴

For example, message _GetResponse will create PB__GetResponse but the rest of the generated code will still try to reference _GetResponse.
@schwern schwern added the bug 🐛 🐞 Something isn't working label Nov 3, 2022
@schwern schwern self-assigned this Nov 3, 2022
@schwern schwern mentioned this issue Nov 3, 2022
Closed
4 tasks
@schwern
Copy link
Contributor Author

schwern commented Nov 4, 2022

Here's the bug report.
grpc/grpc#31551

schwern added a commit that referenced this issue Nov 4, 2022
@schwern
feature: Generate protocol buffer classes.
bb0595c 
`grpc_tools_ruby_protoc --proto_path=../client_protos/proto/ --ruby_out=./lib --grpc_out=./lib cacheclient.proto controlclient.proto`

These are broken and will be patched. See #12.
@nog
Copy link

nog commented Apr 28, 2023

grpc/grpc#31551

Looking at the bug report, it now looks like this problem is solvable.

@nog
Copy link

nog commented Apr 30, 2023

Sorry, it was merged, but still in pre-release stage.

@schwern schwern removed their assignment Sep 12, 2023
@schwern
Copy link
Contributor Author

schwern commented Sep 12, 2023

This was released in 1.55.0. grpc/grpc@401c382

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked bug 🐛 🐞 Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nog @schwern @cprice404