Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add java example code for secrets manager #318

Closed
wants to merge 1 commit into from

Conversation

pratik151192
Copy link
Contributor

@pratik151192 pratik151192 commented Jun 29, 2023

Updated secrets manager page with Java example. I have also added a new helper on the sdk package with similar logic and tested that it worked succesfully. Currently waiting on a PR on the sdk package to be approved and merged before I cherry-pick the secrets manager commit on my local.

</TabItem>
<TabItem value="java" label="Java" default>

```java
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey this is really cool! thanks for doing it. I would like to show you something about our docs tomorrow morning, I think there might be a better place for us to put this code. I'll ping you and we can find a time to zoom

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! have also added a new helper on the sdk package examples with similar logic and tested that it worked succesfully. Currently waiting on
the previous PR on the sdk package to be approved and merged before I cherry-pick the secrets manager commit on my local.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cprice404 so we are holding off on this PR until you get this code into the SDK repo and be able to link back to this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is what I want to discuss with Pratik, yes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes am closing this and will generate a new PR with pages just linking to the examples under SDK folders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants