Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review CohortAnalysis._remove_low_hpo_terms #92

Closed
ielis opened this issue Oct 26, 2023 · 2 comments · Fixed by #88
Closed

Review CohortAnalysis._remove_low_hpo_terms #92

ielis opened this issue Oct 26, 2023 · 2 comments · Fixed by #88
Labels
enhancement New feature or request

Comments

@ielis
Copy link
Member

ielis commented Oct 26, 2023

The function for removing infrequent HPO terms does not take into account the annotation propagation. Should we consider annotation propagation when deciding about term frequency?
@ielis ielis added the question Further information is requested label Oct 26, 2023
@pnrobinson
Copy link
Member

I think we should

@ielis
Copy link
Member Author

ielis commented Oct 26, 2023

OK, thanks! We'll work it into the analysis!

@ielis ielis added enhancement New feature or request and removed question Further information is requested labels Oct 26, 2023
@ielis ielis mentioned this issue Oct 26, 2023
Merged
@ielis ielis linked a pull request Oct 26, 2023 that will close this issue
Streamline predicate/analysis workflow #88
Merged
@ielis ielis closed this as completed in #88 Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Streamline predicate/analysis workflow monarch-initiative/gpsea
2 participants
@pnrobinson @ielis