Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding zinc finger to ProteinFeatures #346

Merged
merged 6 commits into from
Nov 13, 2024
Merged

adding zinc finger to ProteinFeatures #346

merged 6 commits into from
Nov 13, 2024

Conversation

pnrobinson
Copy link
Member

@ielis
There are many errors related to allele_count. These are not related to this PR. Is this a known issue or should I try to fix?

@ielis
Copy link
Member

ielis commented Nov 12, 2024

I do not see any issue with allele_count in the context of this PR. The CI fails because of a REST API timeout, which is a common issue.
If you see

UNEXPECTED EXCEPTION: HTTPError('429 Client Error: TOO MANY REQUESTS for url: https://rest.variantvalidator.org/VariantValidator/tools/gene2transcripts/NM_181486.4')

then pls just re-run the CI until it passes.

@pnrobinson
Copy link
Member Author

Can you please check this locally? Why I run pytest in Pycharm I get about 20 errors because of this.

@ielis
Copy link
Member

ielis commented Nov 12, 2024

One CI ran OK (3.11), which should mean that the issue is local to your environment. The CI run for 3.10 stopped due to timeout, leading to cancellation of 3.12.

So, thanks to 3.11 finishing, I am almost sure that the PR will pass on my side.

@ielis
Copy link
Member

ielis commented Nov 13, 2024

Fixes #344

@ielis ielis merged commit 4263bca into develop Nov 13, 2024
3 checks passed
@ielis ielis deleted the zinc_finger branch November 13, 2024 15:12
@ielis ielis mentioned this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants