-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streamline predicate/analysis workflow #88
Conversation
…lyPredicate`, since it is its specialization. Improve documentation.
…`CommunistCohortAnalysis`.
…ypeAnalysisResult`.
I'm proposing a revamp to the The from genophenocorr.analysis import configure_cohort_analysis
analysis = configure_cohort_analysis(cohort, hpo) You'll get an analysis with default options. If you want to tweak the options, build the from genophenocorr.analysis import CohortAnalysisConfiguration
configuration = CohortAnalysisConfiguration.builder()
.include_sv(True)
.pval_correction('fdr_bh')
.build()
analysis = configure_cohort_analysis(cohort, hpo, configuration) Then we run the analysis, e.g. to compare MISSENSE vs others: from genophenocorr.model import VariantEffect
from genophenocorr.analysis.predicate import BooleanPredicate
results = analysis.compare_by_variant_effect(VariantEffect.MISSENSE_VARIANT, tx_id='NM_1234.5')
result_df = results.summarize(hpo, BooleanPredicate.YES)
result_df.head() We get Note that we provide This is what the PR adds. Thanks to the changes, we have a general framework for applying genotype and phenotype predicates and showing the results. Please check out the code, try it out and we can discuss in greater detail the next time. |
# Conflicts: # src/genophenocorr/analysis/predicate/_all_predicates.py # src/genophenocorr/model/_cohort.py # src/genophenocorr/model/_variant.py
…e of `ProteinMetadata.get_features_variant_overlaps()`.
Now, with the |
Fixes #87 , #92
Depends on #94