Added an option to the scramble phenopackets command to allow for a local cached ontology file #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julesjacobsen
requested changes
Sep 20, 2024
There was a problem hiding this comment.
If you added all the scramble_phenopackets functions as methods on the HpoRandomiser class then you wouldn't have to change the method signature of all of these as where the ontology was coming from would be dealt with once when constructing the HpoRandomiser
julesjacobsen
approved these changes
Sep 26, 2024
yaseminbridges
deleted the
359-add-option-to-allow-cached-version-of-the-ontology-files
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the specification of hp.obo/hp.json etc etc to be consumed by OAK and used in the workflow for scrambling phenopackets in place of fetching remotely