Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(EditableTypography): fix specificity issues when changing types a… #2028

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

shaharzil
Copy link
Contributor

@shaharzil shaharzil requested a review from a team as a code owner March 19, 2024 11:23
Copy link
Contributor

@YossiSaadi YossiSaadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! do we plan on removing the typographyClassName usage on both EditableX components? or is there a reason they're still there?

edit: I wasn't clear I think, I know we agreed on leaving both for the solution, but do we plan on removing the class later?

@shaharzil
Copy link
Contributor Author

Great! do we plan on removing the typographyClassName usage on both EditableX components? or is there a reason they're still there?

edit: I wasn't clear I think, I know we agreed on leaving both for the solution, but do we plan on removing the class later?

It is problematic for 2 reasons:

  1. It can be a breaking change
  2. the input needs it, otherwise it won't have the correct style (can be solved of course with some specificity with the selector)

So yes, we want to remove it but not now :) (I can open a task for it)

@YossiSaadi
Copy link
Contributor

Great! do we plan on removing the typographyClassName usage on both EditableX components? or is there a reason they're still there?
edit: I wasn't clear I think, I know we agreed on leaving both for the solution, but do we plan on removing the class later?

It is problematic for 2 reasons:

  1. It can be a breaking change
  2. the input needs it, otherwise it won't have the correct style (can be solved of course with some specificity with the selector)

So yes, we want to remove it but not now :) (I can open a task for it)

hmm got ya
we can create a task with a very low priority, yep

@shaharzil shaharzil merged commit bebcdbd into master Mar 19, 2024
10 checks passed
@shaharzil shaharzil deleted the fix-editable-typography-props branch March 19, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Editable heading type is not taken
2 participants