Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: delete v2 storybook publish workflow #2636

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Conversation

talkor
Copy link
Member

@talkor talkor commented Dec 9, 2024

@talkor talkor requested a review from a team as a code owner December 9, 2024 13:02
Copy link
Contributor

@YossiSaadi YossiSaadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've talked to @rivka-ungar about it
it's redundant to have this extra workflow

let's remove entirely this file, and have a different file content at version2 branch

the version2 branch content should not have workflow_run at all (as it runs only for the default branch)

@talkor
Copy link
Member Author

talkor commented Dec 9, 2024

I've talked to @rivka-ungar about it it's redundant to have this extra workflow

let's remove entirely this file, and have a different file content at version2 branch

are you sure it will work? It used to be that way before and it didn't work

@YossiSaadi
Copy link
Contributor

I've talked to @rivka-ungar about it it's redundant to have this extra workflow
let's remove entirely this file, and have a different file content at version2 branch

are you sure it will work? It used to be that way before and it didn't work

yep, @rivka-ungar ran it earlier and it worked

@YossiSaadi
Copy link
Contributor

remove this file entirely and remove the workflow_run from the version2's branch publish-storybook.yml

@YossiSaadi
Copy link
Contributor

@talkor talkor requested a review from YossiSaadi December 11, 2024 12:37
@talkor talkor changed the title ci: run publish v2 storybook on version2 branch ci: deletev2 storybook publish workflow Dec 11, 2024
@talkor talkor changed the title ci: deletev2 storybook publish workflow ci: delete v2 storybook publish workflow Dec 11, 2024
@talkor talkor merged commit 766d3ce into master Dec 11, 2024
7 checks passed
@talkor talkor deleted the ci/fix-storybook-v2-workflow branch December 11, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants