Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Tipseen): allow referenceWrapperClassName prop for component #2652

Merged

Conversation

stasshw
Copy link
Contributor

@stasshw stasshw commented Dec 15, 2024

Wrapping the element with a Tipseen wraps it in an empty span, which interferes with the CSS. Passing the missing property to the inner component ensures the correct styling is applied.

https://monday.monday.com/boards/5703104356/pulses/8039110583

image

another way to go would be to add a default class name here: https://github.com/stasshw/vibe/blob/24828d7f2ffec00084775f56322518cc04c9a2b8/packages/core/src/components/Dialog/Dialog.tsx#L519

…issue

Wrapping the element with a Tipseen wraps it in an empty span, which interferes with the CSS. Passing the missing property to the inner component ensures the correct styling is applied.

https://monday.monday.com/boards/5703104356/pulses/8039110583
@stasshw stasshw requested a review from a team as a code owner December 15, 2024 10:38
@YossiSaadi
Copy link
Contributor

Hey @stasshw, what do you mean about a default class?

@stasshw stasshw changed the title fix(ui): pass missing property to inner component to resolve styling issue fix(TipSeen): pass missing property to inner component to resolve styling issue Dec 15, 2024
@stasshw stasshw changed the title fix(TipSeen): pass missing property to inner component to resolve styling issue fix(Tipseen): pass missing property to inner component to resolve styling issue Dec 15, 2024
@stasshw
Copy link
Contributor Author

stasshw commented Dec 15, 2024

Hey @stasshw, what do you mean about a default class?

@YossiSaadi just add any class even without a prop from outside (currently it's a span without any class)

@YossiSaadi
Copy link
Contributor

Hey @stasshw, what do you mean about a default class?

@YossiSaadi just add any class even without a prop from outside (currently it's a span without any class)

you mean so you'll be able to "target" the element in a non-moduled css?
it can work, but it's probably a less good solution

@YossiSaadi YossiSaadi changed the title fix(Tipseen): pass missing property to inner component to resolve styling issue feat(Tipseen): pass missing property to inner component to resolve styling issue Dec 15, 2024
@YossiSaadi YossiSaadi changed the title feat(Tipseen): pass missing property to inner component to resolve styling issue feat(Tipseen): allow referenceWrapperClassName prop for component Dec 15, 2024
@stasshw
Copy link
Contributor Author

stasshw commented Dec 15, 2024

Hey @stasshw, what do you mean about a default class?

@YossiSaadi just add any class even without a prop from outside (currently it's a span without any class)

you mean so you'll be able to "target" the element in a non-moduled css? it can work, but it's probably a less good solution

ok thank you

@YossiSaadi YossiSaadi merged commit 9d6fcc2 into mondaycom:master Dec 15, 2024
7 of 8 checks passed
stasshw added a commit to stasshw/vibe that referenced this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants