fix(Modal): Esc should be scoped to the current top modal and not to close all modals #2698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…close all modals it used to work in a way that the Esc is registered to the document body, so every Esc anywhere in the document closed ALL the modals
rivka-ungar
approved these changes
Jan 1, 2025
YossiSaadi
deleted the
fix/yossi/new-modal-esc-closes-all-modals-and-prevents-esc-from-8136384041
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it used to work in a way that the Esc is registered to the document body, so every Esc anywhere in the document closed ALL the modals
https://monday.monday.com/boards/3532714909/pulses/8136384041