feat(Modal): wrap the overlay and modal inside a container, to allow portaling with layer provider to the container #2703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new prerelease version of this PR has been published! 🎉 To update Or with npm: |
talkor
approved these changes
Jan 6, 2025
Base automatically changed from
feat/yossi/new-modal-allow-passing-reactnode-to-title-prop-8129253861-allow-passing-aria-labelledby-and-aria-describedby--8129247306
to
master
January 6, 2025 12:21
…portaling with layer provider to the container
YossiSaadi
force-pushed
the
fix/yossi/new-modal-floating-components-tooltip-menu-etc-are-rendered-8165813476
branch
from
61006db to
5eb50f4
Compare
YossiSaadi
deleted the
fix/yossi/new-modal-floating-components-tooltip-menu-etc-are-rendered-8165813476
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done to fix LayerProvider items are wrapped behind the modal's z-index.
and it seem to be a better practice to wrap the overlay and modal.
https://monday.monday.com/boards/3532714909/pulses/8165813476