-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
componentname
is not being set in DoughBaseComponent
#218
Comments
ourmaninamsterdam
added a commit
that referenced
this issue
Feb 18, 2015
ourmaninamsterdam
added a commit
that referenced
this issue
Feb 18, 2015
ourmaninamsterdam
added a commit
to moneyadviceservice/cms
that referenced
this issue
Feb 19, 2015
See moneyadviceservice/dough#218 for more details.
ourmaninamsterdam
added a commit
that referenced
this issue
Feb 24, 2015
ourmaninamsterdam
added a commit
that referenced
this issue
Feb 25, 2015
ourmaninamsterdam
added a commit
that referenced
this issue
Mar 11, 2015
ourmaninamsterdam
added a commit
that referenced
this issue
May 1, 2015
ourmaninamsterdam
added a commit
that referenced
this issue
May 8, 2015
ourmaninamsterdam
added a commit
that referenced
this issue
May 12, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When initialising components using componentLoader, the
componentName
is derived from thedata-dough-component
attribute specified on the component's DOM element. This is then passed across in the config into DoughBaseComponent. Once the component has been initialised, its element is stamped withdata-dough-[componentname]-initialised="yes"
. A record of the component is also kept in a component manifest.However, as
componentLoader
isn't used, when directly instantiating a componentnew TabSelector()
, the component name is never passed across and thus the element isn't stamped withdata-dough-[componentname]-initialised="yes"
.The text was updated successfully, but these errors were encountered: