Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HTML options recursion #349

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Fix HTML options recursion #349

wants to merge 19 commits into from

Commits on May 11, 2023

  1. Fix recursion issue 

    This recurses under Ruby > 2.6.
    @benlovell
    benlovell committed May 11, 2023
    Configuration menu
    Copy the full SHA
    6acfadd View commit details
    Browse the repository at this point in the history

  2. Add GitHub CI workflow

    @benlovell
    benlovell committed May 11, 2023
    Configuration menu
    Copy the full SHA
    bd318ed View commit details
    Browse the repository at this point in the history

  3. Modernise Ruby 

    Upgrades necessary to use a more recent Ruby and to remove the MAS dev
dependencies gem that is not used.
    @benlovell
    benlovell committed May 11, 2023
    Configuration menu
    Copy the full SHA
    e4896cd View commit details
    Browse the repository at this point in the history

  4. Standardise Ruby version selector

    @benlovell
    benlovell committed May 11, 2023
    Configuration menu
    Copy the full SHA
    715eef6 View commit details
    Browse the repository at this point in the history

  5. Upgrade Rubocop for compatibility

    @benlovell
    benlovell committed May 11, 2023
    Configuration menu
    Copy the full SHA
    2038b5a View commit details
    Browse the repository at this point in the history

  6. Add node binaries to PATH

    @benlovell
    benlovell committed May 11, 2023
    Configuration menu
    Copy the full SHA
    3089d49 View commit details
    Browse the repository at this point in the history

  7. Explicitly install bower

    @benlovell
    benlovell committed May 11, 2023
    Configuration menu
    Copy the full SHA
    5d1787d View commit details
    Browse the repository at this point in the history

  8. Try setting the binaries path

    @benlovell
    benlovell committed May 11, 2023
    Configuration menu
    Copy the full SHA
    acd0021 View commit details
    Browse the repository at this point in the history

  9. Use the npm script instead

    @benlovell
    benlovell committed May 11, 2023
    Configuration menu
    Copy the full SHA
    12fc729 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2023

  1. Switch to headless chrome

    @benlovell
    benlovell committed May 12, 2023
    Configuration menu
    Copy the full SHA
    3126516 View commit details
    Browse the repository at this point in the history

  2. Correct spec failure flakiness

    @benlovell
    benlovell committed May 12, 2023
    Configuration menu
    Copy the full SHA
    680cfb1 View commit details
    Browse the repository at this point in the history

  3. Correct chai syntax

    @benlovell
    benlovell committed May 12, 2023
    Configuration menu
    Copy the full SHA
    c84c153 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. WIP: Rails upgrade to 6.x

    @benlovell
    benlovell committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    57908e3 View commit details
    Browse the repository at this point in the history

  2. WIP: Changes to view context

    @benlovell
    benlovell committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    4781f45 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. Simplify rendering

    @benlovell
    benlovell committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    0697a3e View commit details
    Browse the repository at this point in the history

  2. Simplify rendering and error handling

    @benlovell
    benlovell committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    13a9483 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. Workaround odd OpenStruct issue 

    Due to differences in Ruby 2.7/3.0 The field isn't correctly initialised
otherwise.
    @benlovell
    benlovell committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    d59e150 View commit details
    Browse the repository at this point in the history

  2. Rubocop

    @benlovell
    benlovell committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    ec2d70d View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Adds PostMessages component 

    - Designed to communicate between iFrame and parent on MoneyHelper
    @davidtrussler @benlovell
    davidtrussler authored and benlovell committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    e3ce7d1 View commit details
    Browse the repository at this point in the history